-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing improvements and several fixes #321
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # examples/CMakeLists.txt # examples/client_https_get.c # examples/tneat.c # neat_core.c
This reverts commit 463f038.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge PR, sorry ... :)
Changes:
closing mechanism refactoring
If a peer closes the transport connection, this is now indicated by the
on_close
event and not by receiving no data when callingneat_read
.According to #316
callback handling
The callback handling has been improved in many aspects.
For example
on_all_written
is called every time aneat_write
call has successfully delivered data to the transport layer and the flow buffer is drained.See #272
improved memory management
The library should now handle memory a lot better, valgrind is much happier now. :)
misc changes
Comments welcome...