Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database migrations for contributor audio and curation #274

Merged
merged 5 commits into from
May 18, 2023

Conversation

CharlieMcVicker
Copy link
Collaborator

@CharlieMcVicker CharlieMcVicker commented May 4, 2023

Before anything else, I recommend the rich diff tool for reading the Markdown table changes!

Tracking

This is required to ship these two tickets.
[DP-186] As a contributor, I want the ability to upload audio to DAILP
[DP-200] As a contributor, I want to be able to see user contributed audio

Context

We have three main kinds of users Contributors, Editors, and Readers.

  • Contributors should be able to upload their own readings of individual words on the site
  • Contributors and Editors should be able to see all other contributor audio
  • Editors should be able to select one of the user-contributed audios to be shown to Readers
  • Readers should only see curated audio
  • Curated audio is either selected by an Editor or ingested via the big migration process from Google Sheets

Related work

I have a frontend PR (#268) going for this stuff, which will eventually include the GQL mutations that touch this stuff. I want to do these DB migrations on their own so that PR doesn't get any bigger.

@CharlieMcVicker CharlieMcVicker marked this pull request as ready for review May 4, 2023 18:58
@GracefulLemming GracefulLemming merged commit 258ebaf into main May 18, 2023
GracefulLemming added a commit that referenced this pull request May 18, 2023
…rations"

This reverts commit 258ebaf, reversing
changes made to cb3334b.
@GracefulLemming
Copy link
Contributor

I guess the SQL you wrote is somehow disagreeing with our existing code? I can dig into this more at some point if you'd like

@GracefulLemming GracefulLemming deleted the cm/contributor-audio-migrations branch May 26, 2023 21:48
@CharlieMcVicker CharlieMcVicker restored the cm/contributor-audio-migrations branch July 6, 2023 16:42
@CharlieMcVicker
Copy link
Collaborator Author

@GracefulLemming can we circle back on this? I'm going to rewrite the migrations for multiple surfaced audio segments. Then can we review why this shut down production last time we merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants