Update the ome_zarr channel #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volume slicing refactoring
in preparation of creating a python package out of it.
* Ran black for a more objective code style * Fixed some type annotations (mostly in order to understand the better understand the code * Added more docstrings mostly in order to better understand the code * Ensured google-style docstrings
Note: This changes the behavior a bit. Previous version was opening the tiff file and immediately unlinking the file, such that it was deleted once tifffile closed the handle. However, this was not supported on windows, where a blank try except was employed to hide it and also obscure what was really happening. Now the behavior on all osses is the same and users can employ the os-specific way to clean up their temp folder.
would prefer to remove the special handling of fetching extra metadata as it's also not used in the tutorial. Typing gets ugly with the different return types.
it's also not really good practice.
Move OpenIJTIFF python to module/conda-package
|
Hi @bugraoezdemir, |
|
Instead of creating a new ome_zarr branch, I just merged the master branch to the existing ome_zarr branch, and that branch was very old, hence so many commits. Anyways, at the moment, the ome_zarr branch is up to date with the master branch. So there should be no problem. I will add my updates to this ome_zarr branch. |
|
Oh, I see, you merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.