Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional loss functions #262

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Adds additional loss functions #262

merged 4 commits into from
Mar 22, 2024

Conversation

georgeyiasemis
Copy link
Contributor

Adds:

  • High frequency error norm (hfen) as loss and metric
  • Signal-to-noise ratio (snr) loss
  • SSIM 3d loss
  • Tests

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 88.73239% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 84.05%. Comparing base (39e7680) to head (aec9327).

Files Patch % Lines
direct/functionals/hfen.py 81.08% 14 Missing ⚠️
direct/nn/mri_models.py 87.93% 7 Missing ⚠️
direct/functionals/snr.py 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   84.40%   84.05%   -0.36%     
==========================================
  Files          93       93              
  Lines        6645     6486     -159     
==========================================
- Hits         5609     5452     -157     
+ Misses       1036     1034       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some minor comments.

direct/functionals/__init__.py Show resolved Hide resolved
direct/functionals/ssim.py Show resolved Hide resolved
direct/nn/mri_models.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit b56a724 into main Mar 22, 2024
11 checks passed
@georgeyiasemis georgeyiasemis deleted the funs branch March 23, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants