Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors DirectEnums to uppercase #266

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

georgeyiasemis
Copy link
Contributor

Refactors attributes of DirectEnum-derived classes to uppercase.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 89.87342% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 84.08%. Comparing base (b56a724) to head (97d8909).

Files Patch % Lines
direct/data/mri_transforms.py 84.44% 7 Missing ⚠️
direct/nn/get_nn_model_config.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   84.05%   84.08%   +0.02%     
==========================================
  Files          93       93              
  Lines        6486     6504      +18     
==========================================
+ Hits         5452     5469      +17     
- Misses       1034     1035       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit dd3beed into main Mar 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All DirectEnums must have attributes in uppercase
2 participants