Add nsec3-hash command. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximon18
requested review from
partim,
tertsdiepraam,
bal-e,
Philip-NLnetLabs and
a team
and removed request for
partim,
tertsdiepraam,
mozzieongit,
Philip-NLnetLabs and
bal-e
12 tasks
…g is not specified which will be fixed by PR #428.
… an existing 3rd party ldns Docker image.
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
mozzieongit
previously approved these changes
Nov 14, 2024
tertsdiepraam
requested changes
Nov 14, 2024
Merged
Merged
ximon18
commented
Nov 21, 2024
ximon18
commented
Nov 21, 2024
ximon18
commented
Nov 21, 2024
ximon18
commented
Nov 21, 2024
ximon18
commented
Nov 21, 2024
ximon18
commented
Nov 21, 2024
ximon18
commented
Nov 21, 2024
|
LGTM @tertsdiepraam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: A minimal working version of this command already existed in
mainbut used code copied fromdomainrather than depending ondomain.Currently depends on
domainbranchinitial-nsec3-generation, see NLnetLabs/domain#416.Contains several kinds of tests:
tests/(ignored by default) that compare outputs to a host installedldns-nsec3-hashcommand.Fuzz tests and man page changes were moved out to #24 and #25.