Add keygen command. #9
Conversation
This reverts commit 643ab86. See: <#9 (comment)>
src/commands/keygen.rs
Outdated
| public_key.algorithm().to_int(), | ||
| public_key.key_tag() | ||
| ); | ||
| // TODO: Adjust for how 'Env' mocks the current directory. |
There was a problem hiding this comment.
It's on main so you could do this (and make all this testable)
There was a problem hiding this comment.
Ah yeah, I need to rebase now.
| make_ksk: bool, | ||
|
|
||
| /// Whether to create symlinks. | ||
| #[arg(short, long, value_enum, num_args = 0..=1, require_equals = true, default_missing_value = "yes", default_value = "no")] |
There was a problem hiding this comment.
Could you make the short = 's' and long = "symlink" explicit?
There was a problem hiding this comment.
This needs a massive comment to explain the rest of the attributes you put on here as well.
| algorithm = parse_os_with("algorithm (-a)", &parser.value()?, |s| { | ||
| Ok(match s { | ||
| "list" => { | ||
| // TODO: Mock stdout and process exit? |
There was a problem hiding this comment.
This is possible after the notify branch is merged, where parse_ldns takes Env as well.
|
|
||
| Arg::Short('r') => { | ||
| // NOTE: '-r' can be repeated; we don't use it, so the order doesn't matter. | ||
| let _ = parser.value()?; |
There was a problem hiding this comment.
Do we want to warn or error here? Sounds like something that could lead to unexpected behaviour.
| impl From<Keygen> for Command { | ||
| fn from(value: Keygen) -> Self { | ||
| Self::Keygen(value) | ||
| } | ||
| } |
There was a problem hiding this comment.
I put all of these in commands/mod.rs, though maybe you're right it should be here.
|
|
||
| /// Create a symlink, overwriting if it already exists. | ||
| #[cfg(unix)] | ||
| fn fs_symlink_force(&self, target: impl AsRef<Path>, link: impl AsRef<Path>) -> Result<()> { |
There was a problem hiding this comment.
I'm not sure about adding higher-level API's than std here.
WIP.