Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSEC3 salt strings should only be accepted if within the salt size limit. #431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ximon18
Copy link
Member

@ximon18 ximon18 commented Oct 30, 2024

Prior to this PR, converting a hex string to an Nsec3Salt succeeds even if the string represents more than the maximum 255 bytes of salt allowed.

@ximon18 ximon18 added breaking A PR that includes a breaking change. needs-review labels Oct 30, 2024
@ximon18 ximon18 requested a review from a team October 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A PR that includes a breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants