Support zone file formatting using tabs instead of spaces. #445
+37
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eparate `FormatWriter` and (b) that only uses tabs between record fields and not between rdata values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on initial internal feedback this is expected to be updated to use a separate
FormatWriter.It also currently wrongly uses tabs between record fields AND between rdata values, while rdata values should be padded by spaces.
This PR is about matching current LDNS zone file output format.
It may make more sense for this not to be part of
domainat all if possible as I can imagine that formatting is an opinionated thing?