Use SWIG_AppendOutput to support swig 4.3 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swig has changed language specific AppendOutput functions. But helper macro SWIG_AppendOutput remains unchanged. Use that everywhere instead of SWIG_Python_AppendOutput, which would require one extra parameter since swig 4.3.0. https://github.com/swig/swig/blob/v4.3.0/CHANGES.current#L376 swig/swig#2905
|
I admit I am not sure how to test this change, whether it does not break functionality. But it builds. Original patch provided by swig maintainer. |
|
It seems most of failues are caused by not implemented CLA and IPN records, from https://datatracker.ietf.org/doc/draft-johnson-dns-ipn-cla/07/. Not related to these changes. |
|
PR #257 seems to be a duplicate of this proposal. Not sure if proposed by original change author, do not know his or her name. |
|
I'll have a look (also at the differences of the two PRs) next week or so, and credit both of you if it is indeed similar ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swig has changed language specific AppendOutput functions. But helper macro SWIG_AppendOutput remains unchanged. Use that everywhere instead of SWIG_Python_AppendOutput, which would require one extra parameter since swig 4.3.0.
https://github.com/swig/swig/blob/v4.3.0/CHANGES.current#L376 swig/swig#2905