Runtime types by value #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how runtime values are treated significantly. Previously, Roto got a pointer to any runtime value. However, that means that they can't be returned (since the pointee will be deallocated) and in general makes it hard to reason about the correctness. Now, runtime types are passed by value.
To pass a type in by value, we wrap it in
Val<T>(for specialization reasons), Roto will take care of the rest.The types you register now must implement either
CopyorClone. Something that isn'tClonecan be made clone by wrapping it in anArc.We can think about reference types later.