Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202411 Release of FV3 Dynamical Core #364

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

laurenchilutti
Copy link
Contributor

Description

This PR publishes the FV3 Dynamical Core 202411 release. This release coincides with the release of SHiELD_physics 202411.

The changes included in this PR are from the GFDL FV3 Team. Full description of changes can be seen in the RELEASE.md

PRs that are all related and should be merged with this one:
SHiELD_physics PR #58
SHiELD_build PR #50

Fixes # (issue)

How Has This Been Tested?

Tested on Gaea

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

RELEASE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell all of our changes have made it into this release. This looks good to me; thank you for undertaking this major task.

@@ -638,11 +638,11 @@ subroutine atmosphere_dynamics ( Time, Surf_diff )
Atm(n)%omga, Atm(n)%ua, Atm(n)%va, Atm(n)%uc, &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a later release I need to re-write this subroutine call so only Atm is passed and not every single one of its members.

RELEASE.md Outdated
- Removed unused Keihl et al. (1994) cloud water effective radius diagnosis
- Driver update (Joseph):
- Implemented a new atmosphere driver to run SHiELD and SHiEMOM with the full FMScoupler.
- Updates to $2\deltaz$ filter (fv_sg) (Lucas, Linjiong):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be $2\delta z$ with a space between 'delta' and 'z', my mistake.

@laurenchilutti laurenchilutti merged commit 162fdc4 into NOAA-GFDL:main Dec 18, 2024
74 checks passed
This was referenced Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants