-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
202411 Release of SHiELD_physics #58
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e2efc0c
release of FV3Team development of phsyics for SHiELD
laurenchilutti 16a337b
revert changes on atmos_shared
laurenchilutti 373f6c6
update RELEASE and README.
laurenchilutti 191539e
rearrange vpert to avoid multiple scaling divisions
JosephMouallem 91d6ecd
enforce DP parameters
JosephMouallem 174f695
remove unnecessary temp arrays
JosephMouallem 8c5cdda
ensure DP cutoff values
JosephMouallem b2804a6
Merge remote-tracking branch 'joseph/repro_fix' into 2024release
laurenchilutti f4b02f6
enforcing DP in the pbl coefficients
laurenchilutti 8fe3638
Merge remote-tracking branch 'origin/main' into 2024release
laurenchilutti 614748b
optimize PBL entrainment/detrainment rate calculations (#2)
gaokun227 6816b01
Add notes and stdout related to co2 scaling (#3)
kaiyuan-cheng f6fc323
Update GFS_layer/GFS_radiation_driver.F90 per Spencer Clark's suggest…
laurenchilutti 890b4ae
Update GFS_layer/GFS_typedefs.F90 removing duplicate allocate
laurenchilutti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this works when non-uniform blocks are created (e.g. [mod (nx, blocksize) != 0]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work with nonuniform blocksizes, to the best of my knowledge. This was a quick 'hack' I put in to get COSP to work in X-SHiELD without running out of memory. This is a limitation of the method at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original code requires the block size to be the same as the layout size, making it much less efficient. Lucas's simple fix resolves this issue, although I haven't tested it in non-uniform blocks.