Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few more tests on HYFeatureNetwork properties #589

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nmizukami
Copy link

@nmizukami nmizukami commented Oct 14, 2022

Added a few tests on HYFeatureNetwork properties: downstream_flowpath_dict and qlateral

Additions

Removals

  • None

Changes

Testing

  1. Performed pytest python -m pytest test_HYFeaturesNetwork.py under test directory

Screenshots

Notes

Todos

Add more tests - e.g., tests on waterbody_connections, results to validate outputs from compute_nhd_routing_v02 function

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@nmizukami nmizukami marked this pull request as ready for review October 14, 2022 20:42
… data is stored in yaml file and is read in test script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant