Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Coastal Runs #834

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

shorvath-noaa
Copy link
Contributor

NOT READY TO MERGE
This contains a few updates to run on v2.2 of the hydrofabric. These edits have been focused on producing valid output for the inland/coastal coupling exercise. The main features are working with v2.2 of the hydrofabric, accessing gage crosswalk information for streamflow nudging, and accessing POI crosswalk information that is now included in the stream_output output files.

TODO
We will need to ensure backwards compatibility with older versions of the hydrofabric. This might not be necessary eventually, but for the time being I believe users are still running t-route on older versions, so we want to maintain that.

Additions

  • Retrieve and pass along poi_crosswalk info from the hydrofabric to output files.

Removals

Changes

  • Access gage information from a new location in the hydrofabric.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant