Make matxHalf trivially copyable (#513)

Set copy ctor and copy assignment methods to default. Also use default ctors for both matxHalf and matxHalfComplex. Thus, the MatX half types no longer initialize to zero.
NVIDIA · Nov 3, 2023 · ae802e6 · ae802e6
1 parent f467cd7
commit ae802e6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 17 deletions.
diff --git a/include/matx/core/half.h b/include/matx/core/half.h
@@ -51,20 +51,17 @@ template <typename T> struct alignas(sizeof(T)) matxHalf {
   using value_type = T; ///< Type of half
 
   /**
-   * @brief Initialize to zero
+   * @brief Default constructor
    * 
    */
-  __MATX_HOST__ __MATX_DEVICE__ __MATX_INLINE__ matxHalf() : x(0.0f) {}
+  __MATX_HOST__ __MATX_DEVICE__ __MATX_INLINE__ matxHalf() = default;
 
   /**
-   * @brief Copy constructor
+   * @brief Default copy constructor
    * 
    * @param x_ Parameter to copy
    */
-  __MATX_HOST__ __MATX_DEVICE__ __MATX_INLINE__ matxHalf(const matxHalf<T> &x_) noexcept
-      : x(x_.x)
-  {
-  }
+  __MATX_HOST__ __MATX_DEVICE__ __MATX_INLINE__ matxHalf(const matxHalf<T> &x_) noexcept = default;
 
   /**
    * @brief Copy constructor from arbitrary type
@@ -79,7 +76,7 @@ template <typename T> struct alignas(sizeof(T)) matxHalf {
   }
 
   /**
-   * @brief Default desctructor
+   * @brief Default destructor
    * 
    */
   __MATX_INLINE__ ~matxHalf() = default;
@@ -115,16 +112,11 @@ template <typename T> struct alignas(sizeof(T)) matxHalf {
   }
 
   /**
-   * @brief Copy assignment operator
+   * @brief Default copy assignment operator
    * 
    * @param rhs Value to copy
    */
-  __MATX_HOST__ __MATX_DEVICE__ __MATX_INLINE__ matxHalf<T> &
-  operator=(const matxHalf<T> &rhs)
-  {
-    x = rhs.x;
-    return *this;
-  }
+  __MATX_HOST__ __MATX_DEVICE__ __MATX_INLINE__ matxHalf<T> &operator=(const matxHalf<T> &rhs) = default;
 
   /**
    * @brief Copy assignment operator

diff --git a/include/matx/core/half_complex.h b/include/matx/core/half_complex.h
@@ -53,10 +53,10 @@ template <typename T> struct alignas(sizeof(T) * 2) matxHalfComplex {
   using value_type = T; ///< Type trait to get type
 
   /**
-   * @brief Constructor a half complex object with defaults of zero
+   * @brief Default constructor
    * 
    */
-  __MATX_HOST__ __MATX_DEVICE__ __MATX_INLINE__ matxHalfComplex() : x(0.0f), y(0.0f) {}
+  __MATX_HOST__ __MATX_DEVICE__ __MATX_INLINE__ matxHalfComplex() = default;
 
   /**
    * @brief Copy constructor from a complex float