Bump NFD to v0.16.2 #735
Merged
Bump NFD to v0.16.2 #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdesiniotis
commented
Jun 8, 2024
deployments/gpu-operator/charts/node-feature-discovery/templates/post-delete-job.yaml
Show resolved
Hide resolved
cdesiniotis
force-pushed
the
bump-nfd-0.16.0
branch
from
4f77a05
to
f1f0eb8
Compare
|
I have verified that this changeset fixes the e2e failures |
tariq1890
requested review from
ArangoGutierrez,
elezar,
shivamerla and
tariq1890
as code owners
|
@tariq1890 could you squash the commits, so it only has the one with v0.16.1, but we don't loose @cdesiniotis contribution |
tariq1890
force-pushed
the
bump-nfd-0.16.0
branch
from
cd5f4d2
to
16150f1
Compare
|
@ArangoGutierrez done. Please check now |
|
Looks sane, leaving the approval to @shivamerla |
shivamerla
reviewed
Jul 3, 2024
deployments/gpu-operator/charts/node-feature-discovery/templates/clusterrole.yaml
Show resolved
Hide resolved
shivamerla
reviewed
Jul 3, 2024
|
@tariq1890 please audit memory requests/limits again to verify they work with scale cluster. If any requests/limits are reduced those are the ones we need to audit first. |
tariq1890
force-pushed
the
bump-nfd-0.16.0
branch
from
16150f1
to
27fb4b7
Compare
Co-authored-by: Tariq Ibrahim <tibrahim@nvidia.com> Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com> bump NFD to v0.16.1 Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
bump-nfd-0.16.0
branch
from
27fb4b7
to
534a1c5
Compare
Done. |
shivamerla
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.