Change order of initialization so pinned pool is available for spill framework buffers #11889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…framework buffers Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
|
build |
|
CI failures due to tests initializing too many times. Before my change we had all of this code under a "make sure Rmm is not initialized already" block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While collecting traces for #11888, I realized that the bounce buffers I am using are pageable, which is pretty bad. If I change the order of initialization, the pinned pool can be initialized before the spill framework, so we can then use pinned memory for the d2h and h2d bounced copies.
Renamed init functions slightly, as their names are not matching their function currently.