Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialpad): addresses the comments made in the last PR review #147

Merged
merged 5 commits into from
Dec 11, 2024
Merged

fix(dialpad): addresses the comments made in the last PR review #147

merged 5 commits into from
Dec 11, 2024

Conversation

Maina-Francis
Copy link
Contributor

Describe your changes

  • Updated function in to handle user fetching with improved parameter handling.
  • Updated the api endpoint to include /api/v2
  • Refined TypeScript interfaces in to ensure type safety and consistency with API responses.
  • Generated and updated Zod schemas in for input validation and data integrity.
  • Updated to reflect the latest changes in user actions and models
  • Improved overall code quality and maintainability by adhering to best practices in TypeScript and Zod validation.

Issue ticket number and link

EXT-294

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set
  • I followed the best practices and guidelines from the Writing Integration Scripts doc

@Maina-Francis
fix(dialpad): addresses the comments made in the last PR review
da5ca4f 
- Updated  function in  to handle user fetching with improved parameter handling.
- Updated the api endpoint to include /api/v2
- Refined TypeScript interfaces in  to ensure type safety and consistency with API responses.
- Generated and updated Zod schemas in  for input validation and data integrity.
- Updated  to reflect the latest changes in user actions and models
- Improved overall code quality and maintainability by adhering to best practices in TypeScript and Zod validation.
Maina-Francis and others added 3 commits December 11, 2024 09:59
@Maina-Francis
fix: user creation request: conditionally include auto_assign
abeff62 
   - Updated the createUser function to only include auto_assign in the request if it is defined.
   - Set the default license value to 'talk' if not provided.
@Maina-Francis
fix: user creation request: set the default value of office_id to null
c7e7200 
   - Set the default value of office_id value to null if its not provided.
@khaliqgant
update flows
7d86818
@khaliqgant khaliqgant self-requested a review December 11, 2024 10:30
@khaliqgant khaliqgant enabled auto-merge (squash) December 11, 2024 10:52
@khaliqgant khaliqgant merged commit 4224887 into main Dec 11, 2024
5 checks passed
@khaliqgant khaliqgant deleted the feature/dialpad-user-provisioning-v2 branch December 11, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaliqgant khaliqgant khaliqgant approved these changes

Assignees

@khaliqgant khaliqgant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maina-Francis @khaliqgant