Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Readme descriptions that say undefined because they're empty #153

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Dec 13, 2024

Describe your changes

Fixes up our readme generator to not show anything after description if it's unset in the nango.yaml. Also adds a warning so they're easier to spot.

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set
  • I followed the best practices and guidelines from the Writing Integration Scripts doc

@nalanj nalanj self-assigned this Dec 13, 2024
@nalanj nalanj requested a review from khaliqgant December 13, 2024 12:50
@nalanj nalanj merged commit 388c1e0 into main Dec 13, 2024
5 checks passed
@nalanj nalanj deleted the alan/empty-readme-descriptions branch December 13, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants