Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update flows sync script to also run doc generation #156

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Dec 16, 2024

Describe your changes

Updates the sync script to also run docs:generate on the nango repo after we copy the flows updates over, so that we get docs snippets updates in that same commit.

Some ramp readmes made it in, probably because they hadn't been run yet otherwise.

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set
  • I followed the best practices and guidelines from the Writing Integration Scripts doc

@nalanj nalanj self-assigned this Dec 16, 2024
@khaliqgant khaliqgant merged commit 8096410 into main Dec 17, 2024
6 checks passed
@khaliqgant khaliqgant deleted the alan/flows-gen-docs branch December 17, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants