Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): [nan-1763] add xero tests and adjust vitest #16

Merged

Conversation

khaliqgant
Copy link
Member

@khaliqgant khaliqgant commented Sep 27, 2024

Describe your changes

Add xero tests. Improve types and remove object casting.

Issue ticket number and link

NAN-1763

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set

Copy link

linear bot commented Sep 27, 2024

Copy link
Contributor

@TBonnin TBonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I have only skimmed through the test data. How do we make sure we don't leak any private info in those test files?

integrations/xero/mappers/to-item.ts Outdated Show resolved Hide resolved
Co-authored-by: Thomas Bonnin <233326+TBonnin@users.noreply.github.com>
@khaliqgant
Copy link
Member Author

lgtm I have only skimmed through the test data. How do we make sure we don't leak any private info in those test files?

We don't unfortunately. Open to suggestions for this. In this case I created test data intentionally so it was all fake.

@khaliqgant khaliqgant merged commit 4bfe2eb into main Sep 27, 2024
5 checks passed
@khaliqgant khaliqgant deleted the khaliq/nan-1763-add-tests-to-more-integration-templates branch September 27, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants