Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integration-tests): fix overrides #18

Closed
wants to merge 1 commit into from

Conversation

hassan254-prog
Copy link
Contributor

Describe your changes

continuation from 2786

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set

@khaliqgant
Copy link
Member

Thanks! Can you move the existing mock files to follow this pattern?

@hassan254-prog
Copy link
Contributor Author

Thanks! Can you move the existing mock files to follow this pattern?

Yes, please go ahead and merge the related PRs so that I can proceed with moving the existing mock files. Thank you!

@hassan254-prog
Copy link
Contributor Author

Incorporated in the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants