Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flows.yaml): [nan-1761] add github app push #3

Conversation

khaliqgant
Copy link
Member

Describe your changes

When the flows.yaml file changes push it to the nango repo so that the file is always up to date. I opted for a Github Action because that seem more fitting to the purposes of a Github App rather than a separate bot user. Additionally a Github App can have special bypass permissions

image

Issue ticket number and link

NAN-1761

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:

  • External API requests have retries

  • Pagination is used where appropriate

  • The built in nango.paginate call is used instead of a while (true) loop

  • Third party requests are parallelized (this can cause issues with rate limits)

  • If a sync requires metadata the nango.yaml has auto_start: false

  • If the sync is a full sync then track_deletes: true is set

@khaliqgant
Copy link
Member Author

Lint issues will be fixed in #2

Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, hopefully it works 👌🏻

@khaliqgant khaliqgant merged commit f1743ca into main Sep 25, 2024
4 of 5 checks passed
@khaliqgant khaliqgant deleted the khaliq/nan-1761-an-update-to-the-integration-scripts-repo-should-push-the branch September 25, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants