Dont increment if no image was found

NatLibFi · Oct 25, 2024 · d1b678a · d1b678a
1 parent 55bb5dc
commit d1b678a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/module/Finna/src/Finna/View/Helper/Root/RecordImage.php b/module/Finna/src/Finna/View/Helper/Root/RecordImage.php
@@ -501,11 +501,10 @@ public function getImagesForBotUser(array $images = []): array
                 $results[] = [
                     'url' => $image['urls'][$size],
                     'pdf' => !empty($image['pdf']),
-                    'id' => $i,
+                    'id' => $i++,
                 ];
                 break;
             }
-            $i++;
         } while ($i < 4 && $image = array_shift($images));
         return $results;
     }

diff --git a/themes/finna2/templates/RecordDriver/DefaultRecord/record-image-paginator.phtml b/themes/finna2/templates/RecordDriver/DefaultRecord/record-image-paginator.phtml
@@ -14,7 +14,7 @@
     <?php if ($image['pdf']): ?>
       <a href="<?=$this->escapeHtmlAttr($image['url'])?>"><?=$this->escapeHtml($image['id']);?></a>
     <?php else: ?>
-      <img src="<?=$this->escapeHtmlAttr($image['url'])?>"><?=$this->escapeHtml($image['id']);?></img>
+      <img src="<?=$this->escapeHtmlAttr($image['url'])?>">
     <?php endif;?>
   <?php
     endforeach;