Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: all test suites #148

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

fix: all test suites #148

wants to merge 21 commits into from

Conversation

SRWieZ
Copy link
Contributor

@SRWieZ SRWieZ commented Dec 22, 2024

Back ports of my finding in #147

Funny thing, I started that other PR to just fix the test suite. Then my curiosity led me on an adventure in the JavaScript ecosystem and its quirks. After that, I was so deep into it that I couldn't stop.

Summary of changes:

  • [JS] Created a base mock for electron in jest
  • [JS] Updated tests that are mocking electron to extend the base one
  • [JS] Fixed jest.config.ts regex
  • [JS] Fixes somes unused imports ans dependencies
  • [PHP] tests against L11 and PHP 8.3
  • [PHP] Fixed test by requiring php-bin^5.0.1 instead of php-bin^5.0.0 with a weird zip.
  • [PHP] Fixed phpstan test suite along side all the errors it did find
  • [PHP] Added composer qa

@SRWieZ SRWieZ changed the title fix: test suite fix: all test suites Dec 22, 2024
@SRWieZ
Copy link
Contributor Author

SRWieZ commented Dec 22, 2024

ALL green! 🎉 ✅

Ready to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant