Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nis]: add local endpoint for querying historical mosaic supplies #547

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Jaguar0625
Copy link
Contributor

problem: historical supplies are needed to properly handle redefined mosaics
solution: add endpoint (local-only) endpoint

@Jaguar0625 Jaguar0625 requested a review from Wayonb August 23, 2024 22:19
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.51%. Comparing base (1793e91) to head (eebe1f8).

Files Patch % Lines
.../nem/nis/dao/retrievers/MosaicSupplyRetriever.java 89.47% 0 Missing and 6 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #547      +/-   ##
============================================
- Coverage     93.52%   93.51%   -0.01%     
- Complexity     5993     6017      +24     
============================================
  Files           709      712       +3     
  Lines         17104    17180      +76     
  Branches       1285     1299      +14     
============================================
+ Hits          15996    16066      +70     
  Misses          862      862              
- Partials        246      252       +6     
Flag Coverage Δ
nem-nis 94.11% <92.30%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nem/nis/controller/MosaicDefinitionController.java 96.72% <100.00%> (+0.42%) ⬆️
...em/nis/controller/requests/BlockHeightBuilder.java 100.00% <100.00%> (ø)
.../java/org/nem/nis/dao/MosaicDefinitionDaoImpl.java 100.00% <100.00%> (ø)
.../nem/nis/dbmodel/DbMosaicDefinitionSupplyPair.java 100.00% <100.00%> (ø)
.../nem/nis/dao/retrievers/MosaicSupplyRetriever.java 89.47% <89.47%> (ø)

Base automatically changed from fix/block-lessor-setting to dev August 26, 2024 14:26
Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@Jaguar0625 Jaguar0625 force-pushed the feature/historical-mosaic-supplies branch from 81c15ba to 3e99201 Compare August 27, 2024 15:35
 problem: historical supplies are needed to properly handle redefined mosaics
solution: add endpoint (local-only) endpoint
@Jaguar0625 Jaguar0625 force-pushed the feature/historical-mosaic-supplies branch from 3e99201 to eebe1f8 Compare August 27, 2024 16:33
@Jaguar0625 Jaguar0625 merged commit eebe1f8 into dev Aug 27, 2024
12 checks passed
@Jaguar0625 Jaguar0625 deleted the feature/historical-mosaic-supplies branch August 27, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants