Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gaussian numbers #1315

Closed
wants to merge 2 commits into from

Conversation

tthsqe12
Copy link
Contributor

should help with oscar-system/Oscar.jl#1379

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1315 (0bc5a62) into master (83d286e) will decrease coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   88.46%   87.96%   -0.50%     
==========================================
  Files          79       75       -4     
  Lines       28962    28043     -919     
==========================================
- Hits        25622    24669     -953     
- Misses       3340     3374      +34     
Impacted Files Coverage Δ
src/Nemo.jl 22.98% <ø> (ø)
src/flint/FlintTypes.jl 94.56% <ø> (ø)
src/flint/fmpz.jl 88.89% <0.00%> (-3.19%) ⬇️
src/flint/fmpq.jl 93.52% <0.00%> (-0.85%) ⬇️
src/arb/arb.jl 85.71% <0.00%> (-0.11%) ⬇️
src/flint/gfp_fmpz_elem.jl 87.95% <0.00%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d286e...0bc5a62. Read the comment docs.

@fingolfin
Copy link
Member

Huh, isn't that a bit of an overreaction? As long as this code is useful to someone, I see no harm in keeping it. The only thing relevant about this code for oscar-system/Oscar.jl#1379 is that the globals QQi and ZZi should not be exported in Oscar.jl. That's all?

@tthsqe12
Copy link
Contributor Author

Nah, I think it can just go to the dust bin:

  • It looks like QQi can never become a number field, which was its raison d'etre
  • Fredrik is going to do these in flint/arb

@tthsqe12
Copy link
Contributor Author

Ah, the continued fractions are being used by oscar test code.

@tthsqe12 tthsqe12 closed this Jun 13, 2022
@tthsqe12 tthsqe12 deleted the remove_gaussian_numbers branch July 14, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants