Advanced concepts: typos, wording, grammar, formatting #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 5, 2024 10:14
This reverts commit e7d3b0c.
0xNeshi
commented
Jun 5, 2024
| @@ -1,6 +1,6 @@ | |||
| # Writing to any storage slot | |||
|
|
|||
| On Starknet, a contract's storage is a map with 2^251 slots, where each slot is a felt which is initialized to 0. | |||
| On Starknet, a contract's storage is a map with \\( 2^{251} \\) slots, where each slot is a `felt252` which is initialized to 0. | |||
0xNeshi
commented
Jun 5, 2024
| @@ -23,14 +23,14 @@ pub mod ListExample { | |||
|
|
|||
| #[storage] | |||
| pub struct Storage { | |||
| amount: List<u128>, | |||
| amounts: List<u128>, | |||
There was a problem hiding this comment.
Plural form indicates a list.
0xNeshi
commented
Jun 5, 2024
| @@ -1,7 +1,6 @@ | |||
| use starknet::SyscallResultTrait; | |||
| use starknet::{Store, SyscallResult}; | |||
| use starknet::storage_access::{StorageBaseAddress, storage_address_from_base_and_offset}; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
./scripts/cairo_programs_verifier.shsuccessfully