address review

NethermindEth · Oct 3, 2023 · 8fc58c1 · 8fc58c1
1 parent e44737d
commit 8fc58c1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/pkg/vm/builtins/range_check.go b/pkg/vm/builtins/range_check.go
@@ -10,7 +10,7 @@ import (
 type RangeCheck struct{}
 
 // 1 << 128
-var max, _ = new(fp.Element).SetString("0x100000000000000000000000000000000")
+var max128 = fp.Element{18446744073700081665, 17407, 18446744073709551584, 576460752142434320}
 
 func (r *RangeCheck) CheckWrite(segment *memory.Segment, offset uint64, value *memory.MemoryValue) error {
 	felt, err := value.ToFieldElement()
@@ -19,13 +19,13 @@ func (r *RangeCheck) CheckWrite(segment *memory.Segment, offset uint64, value *m
 	}
 
 	// felt >= (2^128)
-	if felt.Cmp(max) != -1 {
+	if felt.Cmp(&max128) != -1 {
 		return fmt.Errorf("range check builtin failed for offset: %d value %s", offset, value)
 	}
 	return nil
 }
 
-func (r *RangeCheck) DeduceValue(segment *memory.Segment, offset uint64) error {
+func (r *RangeCheck) InferValue(segment *memory.Segment, offset uint64) error {
 	segment.Data[offset] = memory.EmptyMemoryValueAsFelt()
 	return nil
 }
diff --git a/pkg/vm/builtins/range_check_test.go b/pkg/vm/builtins/range_check_test.go
@@ -33,7 +33,7 @@ func TestRangeCheck(t *testing.T) {
 
 	t.Run("deduce", func(t *testing.T) {
 		segment := memory.EmptySegmentWithLength(3)
-		assert.NoError(t, builtin.DeduceValue(segment, 0))
+		assert.NoError(t, builtin.InferValue(segment, 0))
 		require.Equal(t, memory.EmptyMemoryValueAsFelt(), segment.Data[0])
 	})
 }
diff --git a/pkg/vm/memory/memory.go b/pkg/vm/memory/memory.go
@@ -9,7 +9,7 @@ import (
 
 type BuiltinRunner interface {
 	CheckWrite(segment *Segment, offset uint64, value *MemoryValue) error
-	DeduceValue(segment *Segment, offset uint64) error
+	InferValue(segment *Segment, offset uint64) error
 }
 
 type NoBuiltin struct{}
@@ -18,7 +18,7 @@ func (b *NoBuiltin) CheckWrite(segment *Segment, offset uint64, value *MemoryVal
 	return nil
 }
 
-func (b *NoBuiltin) DeduceValue(segment *Segment, offset uint64) error {
+func (b *NoBuiltin) InferValue(segment *Segment, offset uint64) error {
 	segment.Data[offset] = EmptyMemoryValueAsFelt()
 	return nil
 }
@@ -103,7 +103,7 @@ func (segment *Segment) Read(offset uint64) (MemoryValue, error) {
 
 	cell := &segment.Data[offset]
 	if !cell.Known() {
-		if err := segment.BuiltinRunner.DeduceValue(segment, offset); err != nil {
+		if err := segment.BuiltinRunner.InferValue(segment, offset); err != nil {
 			return MemoryValue{}, err
 		}
 	}

diff --git a/pkg/vm/memory/memory_test.go b/pkg/vm/memory/memory_test.go
@@ -198,7 +198,7 @@ func (b *testBuiltin) CheckWrite(segment *Segment, offset uint64, value *MemoryV
 	return nil
 }
 
-func (b *testBuiltin) DeduceValue(segment *Segment, offset uint64) error {
+func (b *testBuiltin) InferValue(segment *Segment, offset uint64) error {
 	if offset%2 == 1 {
 		return fmt.Errorf("deduce error")
 	}