Chore: Monadic operations for memory values #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-pino
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Cool, when I started working with Go, I craved for some fp. @joshklop wanted even to completely remove the existence of MemoryValue by using an interface, I think that is the right call long term wise. Since this doesn't deter us from that final goal, it is good for me!
| felt *f.Element | ||
| address *MemoryAddress | ||
| } | ||
| type MemoryValue memoryValue |
There was a problem hiding this comment.
You could directly type:
type MemoryValue mo.Either[*f.Element, *MemoryAddress]
I think the type memoryValue is not used anywhere else
There was a problem hiding this comment.
I use its generated cast function
ElijahVlasov
force-pushed
the
chore-monadic
branch
from
2b57126
to
b85a48d
Compare
ElijahVlasov
force-pushed
the
chore-monadic
branch
from
b85a48d
to
fb0279d
Compare
|
I am closing this since MemoryValue has evolved a lot and it is not compatible with current changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't pretend to be a significant improvement :) I think it's kind of nice to take an implementation of Either type so that we don't need to implement one on our own. Feel free to discard this ofc! Just a suggestion