-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement U256InvModN
hint
#631
Conversation
I found the rust implementation to be over engineered, so I followed the python implementation which was very straightforward and is passing the tests. I think performance of both should be the same. But happy to hear your thoughts on it. The tests are done on the examples given here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. I thought you could use the uint256
library for this instead of bigInt, but it's better this way, all the methods are already using bigInt anyway
Fixes: #630