-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feat): Implemented Starknet.go
support for trace endpoints
#25
base: main
Are you sure you want to change the base?
(Feat): Implemented Starknet.go
support for trace endpoints
#25
Conversation
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly check starknet.go to understand how these endpoints are implemented
src/api/rpcspec/methods.ts
Outdated
@@ -585,7 +602,14 @@ const TraceMethods = [ | |||
console.log(transactionTrace); | |||
}); | |||
`, | |||
starknetGo: ``, | |||
starknetGo: `${STARKNET_GO_PREFIX} | |||
result, err := provider.getTransactionTrace(context.Background()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result, err := provider.getTransactionTrace(context.Background()) | |
transactionHash, _ := utils.HexToFelt("0x7641514f46a77013e80215cdce2e55d5aca49c13428b885c7ecb9d3ddb4ab11") | |
result, err := provider.TraceTransaction(context.Background(), transactionHash) |
src/components/Builder.tsx
Outdated
@@ -313,7 +317,34 @@ const Builder = () => { | |||
const updateStarknetGoParams = (currentParamsObj: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updateStarknetGoParams
has now been implemeneted. Please rebase
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the extra space you added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I attempted to remove this, but it appears that there is no extra space. Also, I tried fetching the changes from the upstream 'builder' file, but they are exactly the same. I am uncertain why this issue persists.
@@ -814,7 +829,13 @@ const TraceMethods = [ | |||
block_id, | |||
}, | |||
starknetJs: ``, | |||
starknetGo: ``, | |||
starknetGo: `${STARKNET_GO_PREFIX} | |||
result, err := provider.SimulateTransactions(context.Background(), rpc.BlockID{Tag: "latest"}, transactions, simulationFlags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transactions
and simulation_flags
variables should be defined
…uilder into feat/Abhijay007-Starknet.go-trace-endpoints
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
This PR implements the
starknet-go
support for the following RPC endpoints.starknet_traceTransaction
starknet_traceBlockTransactions
starknet_simulateTransactions
Fixes: #11