fix: Scarb.toml readme & license file not resolved #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the contract is being reoslved and a readme or license file is specified in `Scarb.toml`, the contract resolving logic does not move the readme & licnese file, causing a compilation error during `scarb build`. This PR fixes that by extracing information of these file from `Scarb.toml` and also including them as file being moved to the extracted sub-folder so builds won't fail due to it being missing. Closes #22.
julio4
approved these changes
May 31, 2024
cwkang1998
deleted the
fix/readme_and_license_file_not_moved_to_extracted_folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the contract is being reoslved and a readme or license file is specified in
Scarb.toml, the contract resolving logic does not move the readme & licnese file, causing a compilation error duringscarb build.This PR fixes that by extracing information of these file from
Scarb.tomland also including them as file being moved to the extracted sub-folder so builds won't fail due to it being missing.Closes #22.