Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check if class hash exists for given network #49

Merged
merged 4 commits into from
Jul 18, 2024
Merged

feat: check if class hash exists for given network #49

merged 4 commits into from
Jul 18, 2024

Conversation

liam-nethermind
Copy link
Contributor

@liam-nethermind liam-nethermind commented Jul 15, 2024 •
edited by cwkang1998
Loading

Close #47

Related to internal ticket VOY-2586.

cwkang1998
cwkang1998 reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@cwkang1998 cwkang1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes request, other than that things are good!

crates/cli/src/cli.rs Outdated Show resolved Hide resolved
@cwkang1998 cwkang1998 changed the title [VOY-2586] Check if class hash exists for given network feat: check if class hash exists for given network Jul 17, 2024
cwkang1998
cwkang1998 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@cwkang1998 cwkang1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwkang1998 cwkang1998 merged commit 91c9ad7 into NethermindEth:main Jul 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwkang1998 cwkang1998 cwkang1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if class hash exists for given network
2 participants
@liam-nethermind @cwkang1998