fix: inline submodule imports resolving incorrectly #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the resolution issue resulting from resolver not being able to find the imports. However there's still issues with scarb build failing due to poor reconstruction of the project.
cwkang1998
force-pushed
the
fix/super-imports
branch
from
8f9ccf4
to
69012c3
Compare
cwkang1998
force-pushed
the
fix/super-imports
branch
from
69012c3
to
efa26d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
cairo, a file is considered a module. Resolving file modules are pretty simple as they are usually tied to a single file. However, when attempting to resolve submodules with the resolver, specifically those that are inline submodules, the resolver fails to link the imports with the correct files. This causes a few issues:Most issues comes down to the lack of context during the resolving stage.
This PR attempts to fix that by adding more context on the resolving stage for both the
usestatements and also for each file modules by adding inline submodule information.Closes #11