[Feature/326] 서버에서 블러 이미지 처리하도록 수정 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injoon2019
commented
Sep 18, 2024
Comment on lines
165
to
178
| // fun makeBlurImage() { | ||
| // userProfileService.findAllWithImage().forEach { | ||
| // val imageFile = amazonS3FileService.download(it.imageUrl!!, System.getProperty("java.io.tmpdir")) | ||
| // val blurImage = imageProcessor.blurImage(imageFile) | ||
| // val key = makePathWithUserId(imageFile, it.user.id) | ||
| // amazonS3FileService.upload(blurImage, key) | ||
| // } | ||
| // } | ||
|
|
||
| fun makePathWithUserId( | ||
| file: MultipartFile, | ||
| userId: Long | ||
| ) = "" + userId + FILE_NAME_DELIMITER + LocalDateTime.now() | ||
| .format(DateTimeFormatter.ofPattern("yyyyMMddHHmmss")) + FILE_NAME_DELIMITER + file.originalFilename |
There was a problem hiding this comment.
요거 로컬에서 돌려서 기존 유저들 blurImage를 다 만들어서 주려해요. 궁금한게 원래 makePathWithUserId에서 블러이미지인지, 원본이미지인지 구분을 안해주었던가요??
There was a problem hiding this comment.
그거 imageUploader에 33번째 줄에 있어요! 파일이름 앞에 blurred를 붙여주고 있어요!
injoon2019
force-pushed
the
feature/326
branch
from
d211a4b
to
41e6b1a
Compare
injoon2019
commented
Sep 18, 2024
Comment on lines
+83
to
+87
| @ApiOperation("블러 이미지 생성") | ||
| @PostMapping("/blur-image") | ||
| fun makeBlurImage() { | ||
| adminFacade.makeBlurImage() | ||
| } |
There was a problem hiding this comment.
기존 회원들 blurImage 만들어줄 1회용 api입니다
There was a problem hiding this comment.
넵 맞아요!
- 이 PR 배포하면서 새로 회원가입하는 유저는 blurImage 등록
- 배포 후 어드민 API로 기존 회원들 blurImage 등록
- 그 후 어드민 API 제거
이렇게 할거 같아요
|
제 로컬 노트북이 윈도우인데, 파일 가져올때 윈도우여서 문제 되는 부분이 있네요. 로컬에서 테스트해보려했는데.. |
|
엇 그러면 제가 테스트 해볼까요?-? |
|
오 네 한번만 해주세요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 이슈 번호
close: #326
✨ 작업 내용
서버에서 블러 이미지 처리하도록 수정
🚀 전달 사항
db에 blur_image_url 컬럼 추가는 해놨고, 어드민 api로 기존 유저들에도 blur_image_url이 생긴 후에, 내려주는 이미지 url을 변경할 예정입니다