Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API/further-API-improvements #133

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Conversation

FinnbarHome
Copy link
Collaborator

@FinnbarHome FinnbarHome commented Jan 25, 2024


name: API/further-API-improvements

Pull Request Overview

Brief Description:

Made code more modular and improved error handling

Issue Number:

#123

Related User Story:

#9

Code Changes

Major Changes:

Moved database operations from api_server.js to database.js

Minor Changes:

Made error handling more modular

Testing

Test Cases Covered:

Does it run?

Testing Results:

yes

Documentation

Updated Documentation:

N/A

Review Checklist

  • Code follows project's coding standards.
  • Code is commented and clean.
  • Tests are comprehensive and passing.
  • Documentation is updated and accurate.

@FinnbarHome FinnbarHome added enhancement New feature or request API An API task labels Jan 25, 2024
@FinnbarHome FinnbarHome added this to the API milestone Jan 25, 2024
Copy link
Collaborator

@TheSloanRanger TheSloanRanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheSloanRanger TheSloanRanger merged commit 5f18e30 into dev Jan 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API An API task enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants