Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE/updating-yamls #170

Merged
merged 9 commits into from
Jan 31, 2024
Merged

BE/updating-yamls #170

merged 9 commits into from
Jan 31, 2024

Conversation

Lucca-C
Copy link
Collaborator

@Lucca-C Lucca-C commented Jan 30, 2024


name: Added 2 new YAMLs

Pull Request Overview

Brief Description:

Summary of changes and their purpose.

Issue Number:

#169

Related User Story:

n/a

Code Changes

Major Changes:

  • Added YAML to check if PR has a label
  • Added YAML to check if PR has a milestone

Minor Changes:

  • Centralised templates into one file
  • Merged 2 CI YAMLs into one
  • Standardised naming conventions

Testing

Test Cases Covered:

n/a

Testing Results:

n/a

Documentation

Updated Documentation:

Updated contributing.md to include test and linter commands

Review Checklist

  • Code follows project's coding standards.
  • Code is commented and clean.
  • Tests are comprehensive and passing.
  • Documentation is updated and accurate.

@Lucca-C Lucca-C added the DevOps A DevOps task label Jan 30, 2024
@Lucca-C Lucca-C added this to the DevOps milestone Jan 30, 2024
@Lucca-C Lucca-C self-assigned this Jan 30, 2024
Testing to see if v14 passes
YAML was running in the wrong directory
@Lucca-C Lucca-C requested a review from AmSmef January 31, 2024 16:27
Copy link
Collaborator

@AmSmef AmSmef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmSmef AmSmef merged commit ebb6482 into dev Jan 31, 2024
14 of 16 checks passed
@AmSmef AmSmef deleted the BE/updating-linters branch January 31, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps A DevOps task
Projects
Development

Successfully merging this pull request may close these issues.

2 participants