Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get User's Geolocation #74

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Get User's Geolocation #74

merged 2 commits into from
Jan 23, 2024

Conversation

KyleTait01
Copy link
Collaborator

@KyleTait01 KyleTait01 commented Jan 23, 2024


name: User Geolocation

Pull Request Overview

Brief Description:

Added ability to get user's geolocation which is used to initialise the map

Issue Number:

#34
#35

Related User Story:

#8

Code Changes

Major Changes:

Map now uses geolocation to determine the user's location and zoom in to the appropriate place on the map

Minor Changes:

Added loading screen/icon which displays until the user has allowed location permissions, before loading the map

Testing

Test Cases Covered:

Checks if user's browser has geolocation services functionality before attempting to determine their location

Testing Results:

Loads correctly / displays an error if cannot determine user's location

Documentation

Updated Documentation:

N/A

Review Checklist

  • Code follows project's coding standards.
  • Code is commented and clean.
  • Tests are comprehensive and passing.
  • Documentation is updated and accurate.

@KyleTait01 KyleTait01 added the enhancement New feature or request label Jan 23, 2024
@KyleTait01 KyleTait01 added this to the Front-end milestone Jan 23, 2024
@KyleTait01 KyleTait01 self-assigned this Jan 23, 2024
Copy link
Collaborator

@2418560 2418560 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@Nintails-TF Nintails-TF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I appricate the comments explaining how the map is created.

@Nintails-TF Nintails-TF merged commit e3de1c8 into dev Jan 23, 2024
@Nintails-TF Nintails-TF deleted the FE/geolocation branch January 23, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants