Inline PathSubstitutionGoal::handleChildOutput's empty definition

NixOS · Jul 10, 2024 · 21b4efc · 21b4efc
1 parent d44f06e
commit 21b4efc
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/libstore/build/substitution-goal.cc b/src/libstore/build/substitution-goal.cc
@@ -275,9 +275,6 @@ Goal::Co PathSubstitutionGoal::tryToRun(StorePath subPath, nix::ref<Store> sub,
 }
 
 
-void PathSubstitutionGoal::handleChildOutput(Descriptor fd, std::string_view data) {}
-
-
 void PathSubstitutionGoal::handleEOF(Descriptor fd)
 {
     worker.wakeUp(shared_from_this());

diff --git a/src/libstore/build/substitution-goal.hh b/src/libstore/build/substitution-goal.hh
@@ -72,7 +72,7 @@ public:
     /**
      * Callback used by the worker to write to the log.
      */
-    void handleChildOutput(Descriptor fd, std::string_view data) override;
+    void handleChildOutput(Descriptor fd, std::string_view data) override {};
     void handleEOF(Descriptor fd) override;
 
     /* Called by destructor, can't be overridden */
-Original file line number
+Diff line change
@@ Expand Up @@
     }
-    void PathSubstitutionGoal::handleChildOutput(Descriptor fd, std::string_view data) {}
     void PathSubstitutionGoal::handleEOF(Descriptor fd)
     {
         worker.wakeUp(shared_from_this());
@@ Expand Down @@