Test that the root of a tree produces /nix/store/<hash1>-<hash2>-source #10625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
|
I think it would be good to add a TODO that we should strongly consider changing this. The point of adding these tests should be to detect accidental changes --- not start committing to indefinitely supporting silly bugs in an unstable feature. |
|
@Ericson2314 Good point, created #10627. |
edolstra
force-pushed
the
test-flake-root
branch
from
5e1975e to
5739825
Compare
edolstra
force-pushed
the
test-flake-root
branch
from
5739825 to
f29a220
Compare
Ericson2314
reviewed
Apr 30, 2024
Co-authored-by: John Ericson <git@JohnEricson.me>
Ericson2314
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is really a bug, but unless we decide to make a breaking change, we should test it. (See c5ae41d for the backwards compatibility hack needed on lazy-trees to maintain this behavior.)
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.