packaging: Set darwinMinVersion to fix x86_64-darwin build #11080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported from NixOS/nixpkgs#326172 Co-authored-by: Emily <vcs@emily.moe>
roberth
added
macos
Ericson2314
approved these changes
Jul 11, 2024
cole-h
reviewed
Jul 11, 2024
roberth
commented
Jul 11, 2024
| @@ -11,11 +11,28 @@ | |||
| versionSuffix, | |||
| }: | |||
|
|
|||
| let | |||
| prevStdenv = stdenv; | |||
There was a problem hiding this comment.
Suggested change
| prevStdenv = stdenv; | |
| # Prepare to shadow stdenv in the next scope | |
| prevStdenv = stdenv; |
There was a problem hiding this comment.
Or do we want to use args.stdenv and then shadow stdenv immediately? That might tempt us to use args.stdenv somewhere by accident, probably by forwarding args somewhere.
There was a problem hiding this comment.
I got my sshing to Darwin working again, and now I need this for it to work, so let's decide soon! :)
tomberek
approved these changes
Jul 13, 2024
This comment was marked as resolved.
This comment was marked as resolved.
|
It didn't fix in the dev shell for me, but I assume that's because the dev shell is using a different |
|
Eh, sorry… I forgot to pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Broken build is no good.
Context
TODO: Add x86_64-darwin CI. GitHub switched us to aarch64 some time earlier.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.