Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.conduit, cohttp: → 3.0.0 #103961

Closed
wants to merge 2 commits into from

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Nov 16, 2020

Motivation for this change

Changelogs:

conduit 3.0.0 brings a few breaking API changes. So far it seems there is only really an updated cohttp version for these changes, so merging these updates depends on other packages being updated to reflect the API changes.

Since nothing seems to depend on conduit or cohttp >= 3.0.0 exclusively there also seems to be no rush or the necessity to have two versions in nixpkgs.

Currently the following packages would be broken by this PR:

  • dune-release
  • ocamlPackages.curly
  • ocamlPackages.git-http, ocamlPackages.git-unix, ocamlPackages.irmin-git, ocamlPackages.irmin-http, ocamlPackages.irmin-unix
  • ocamlPackages.opium
  • ocamlPackages.prof_spacetime

To do:

  • cohttp-top
  • cohttp-mirage
  • cohttp-lwt-jsoo
  • conduit-mirage
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 16, 2020
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@sternenseemann
Copy link
Member Author

the OCaml ecosystem has moved past these versions, they were never properly released and changes to conduit have been reverted since.

see #118144

@sternenseemann sternenseemann deleted the conduit-3.0.0 branch March 31, 2021 14:00
@sternenseemann sternenseemann restored the conduit-3.0.0 branch July 24, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: ocaml 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants