home-assistant-custom-components.smartir: replace disutils with packaging
#311375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
reviewed
May 13, 2024
Comment on lines
24
to
27
| postPatch = lib.optionalString (pythonAtLeast "3.12") '' | ||
| substituteInPlace custom_components/smartir/__init__.py \ | ||
| --replace-fail "distutils" "setuptools._distutils" | ||
| ''; |
There was a problem hiding this comment.
Upstream needs to migrate to https://packaging.pypa.io/en/latest/version.html. Can you file an issue or provide a patch?
There was a problem hiding this comment.
smartHomeHub/SmartIR#1250, I'll update this PR with fetchpatch.
…ckaging` - Format using nixfmt-rfc-style - Add passthru.updateScript
azuwis
changed the title
disutils with packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.