Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rosa: 1.2.39 -> 1.2.42 #317409

Closed
wants to merge 1 commit into from
Closed

rosa: 1.2.39 -> 1.2.42 #317409

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jun 5, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for rosa is: CLI for the Red Hat OpenShift Service on AWS

meta.homepage for rosa is: https://github.com/openshift/rosa

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 1.2.40 with grep in /nix/store/w1g2byvwfcy2nmd9dyb4lip43939v2wd-rosa-1.2.40
  • found 1.2.40 in filename of file in /nix/store/w1g2byvwfcy2nmd9dyb4lip43939v2wd-rosa-1.2.40
Rebuild report (if merged into master) (click to expand) 
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

rosa
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/w1g2byvwfcy2nmd9dyb4lip43939v2wd-rosa-1.2.40 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A rosa https://github.com/r-ryantm/nixpkgs/archive/6361d6c6c12c70035803c4a8391d4c520b6ad95a.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/6361d6c6c12c70035803c4a8391d4c520b6ad95a#rosa

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/w1g2byvwfcy2nmd9dyb4lip43939v2wd-rosa-1.2.40
ls -la /nix/store/w1g2byvwfcy2nmd9dyb4lip43939v2wd-rosa-1.2.40/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:
  • rosa
Maintainer pings

cc @jfchevrette for testing.

@ofborg ofborg bot requested a review from jfchevrette June 5, 2024 10:59
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jun 5, 2024
sikmir
sikmir requested changes Jun 9, 2024
View reviewed changes
Copy link
Member

@sikmir sikmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

result/bin/rosa version --client
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x19 pc=0x10ed1c260]

goroutine 1 [running]:
github.com/openshift/rosa/cmd/version.(*RosaVersionOptions).BindAndValidate(0xc000f1fbe8?, {0xc?, 0x27?})
	github.com/openshift/rosa/cmd/version/options.go:59
github.com/openshift/rosa/cmd/version.NewRosaVersionCommand.RosaVersionRunner.func2({0x0?, 0x0?}, 0x0?, 0x0?, {0x0?, 0x0?, 0x0?})
	github.com/openshift/rosa/cmd/version/cmd.go:64 +0x45
github.com/openshift/rosa/cmd/version.NewRosaVersionCommand.DefaultRunner.func3(0xc000a37508, {0xc00006b9a0, 0x0, 0x1})
	github.com/openshift/rosa/pkg/rosa/runner.go:29 +0x10e
github.com/spf13/cobra.(*Command).execute(0xc000a37508, {0xc00006b980, 0x1, 0x1})
	github.com/spf13/cobra@v1.8.0/command.go:987 +0xab1
github.com/spf13/cobra.(*Command).ExecuteC(0x110976b60)
	github.com/spf13/cobra@v1.8.0/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.8.0/command.go:1039
main.main()
	github.com/openshift/rosa/cmd/rosa/main.go:113 +0x93

@jfchevrette jfchevrette mentioned this pull request Jun 10, 2024
Closed
@jfchevrette
Copy link
Member

already reported upstream in openshift/rosa#1955

@wegank wegank marked this pull request as draft June 26, 2024 13:50
jfchevrette
jfchevrette suggested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@jfchevrette jfchevrette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version is out which fixes the build failure we are getting with 1.2.40

https://r.ryantm.com/log/rosa/2024-06-26.log

@r-ryantm r-ryantm changed the title rosa: 1.2.39 -> 1.2.40 rosa: 1.2.39 -> 1.2.41 Jun 26, 2024
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for rosa is: CLI for the Red Hat OpenShift Service on AWS

meta.homepage for rosa is: https://github.com/openshift/rosa

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 1.2.41 with grep in /nix/store/dfincwirzjbq9hyn5dpwqsl6lvhiz12y-rosa-1.2.41
  • found 1.2.41 in filename of file in /nix/store/dfincwirzjbq9hyn5dpwqsl6lvhiz12y-rosa-1.2.41
Rebuild report (if merged into master) (click to expand) 
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

rosa
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/dfincwirzjbq9hyn5dpwqsl6lvhiz12y-rosa-1.2.41 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A rosa https://github.com/r-ryantm/nixpkgs/archive/5069b30d4b29122f4f1e86b81d1e4ca5cfa32c99.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/5069b30d4b29122f4f1e86b81d1e4ca5cfa32c99#rosa

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/dfincwirzjbq9hyn5dpwqsl6lvhiz12y-rosa-1.2.41
ls -la /nix/store/dfincwirzjbq9hyn5dpwqsl6lvhiz12y-rosa-1.2.41/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:
  • rosa
Maintainer pings

cc @jfchevrette for testing.

@ofborg ofborg bot requested a review from jfchevrette June 26, 2024 15:34
@jfchevrette jfchevrette requested a review from sikmir June 27, 2024 11:51
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4172

@r-ryantm r-ryantm changed the title rosa: 1.2.39 -> 1.2.41 rosa: 1.2.39 -> 1.2.42 Jul 22, 2024
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for rosa is: CLI for the Red Hat OpenShift Service on AWS

meta.homepage for rosa is: https://github.com/openshift/rosa

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 1.2.42 with grep in /nix/store/q1938b3dyw2s5x95m5bilr9rycjakjyx-rosa-1.2.42
  • found 1.2.42 in filename of file in /nix/store/q1938b3dyw2s5x95m5bilr9rycjakjyx-rosa-1.2.42
Rebuild report (if merged into master) (click to expand) 
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

rosa
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/q1938b3dyw2s5x95m5bilr9rycjakjyx-rosa-1.2.42 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A rosa https://github.com/r-ryantm/nixpkgs/archive/cf1c3aa0b4f8a049ebb12863389fb0a1692659be.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/cf1c3aa0b4f8a049ebb12863389fb0a1692659be#rosa

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/q1938b3dyw2s5x95m5bilr9rycjakjyx-rosa-1.2.42
ls -la /nix/store/q1938b3dyw2s5x95m5bilr9rycjakjyx-rosa-1.2.42/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • rosa
Maintainer pings

cc @jfchevrette for testing.

@ofborg ofborg bot requested a review from jfchevrette July 22, 2024 22:29
@jfchevrette
Copy link
Member

Closing as I don't seem to have a way to remove draft status. The update bot should open a new PR, I hope

@r-ryantm r-ryantm deleted the auto-update/rosa branch July 26, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir Awaiting requested review from sikmir

@jfchevrette jfchevrette Awaiting requested review from jfchevrette

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r-ryantm @jfchevrette @nixos-discourse @sikmir @wegank