xdg-desktop-portal: Fix installedTests
#344743
Conversation
| if [ -x '${documentFuse}' ] ; then | ||
| wrapGApp '${documentFuse}' | ||
| wrapGApp '${testPortals}' | ||
| cp -r tests/share/applications $installedTests/share |
There was a problem hiding this comment.
Why does not upstream install this?
There was a problem hiding this comment.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
It's been merged, can't fetchpatch it because of conflicts.
Artturin
force-pushed
the
xdgdesktopinst
branch
from
b96c9b9
to
dd777a7
Compare
Artturin
force-pushed
the
xdgdesktopinst
branch
2 times, most recently
from
246e972
to
a87672a
Compare
| testConfig = { | ||
| xdg.portal = { | ||
| enable = true; | ||
| extraPortals = [ pkgs.xdg-desktop-portal-gtk ]; |
There was a problem hiding this comment.
Should these really be using xdg-desktop-portal-gtk? I thought the tests were mostly self-contained. At a quick grep, I do not see any relevant mentions of gtk in the upstream source either.
There was a problem hiding this comment.
Indeed it's not necessary, I added it when trying to get it to work and didn't think to remove it and test if it still works.
Artturin
force-pushed
the
xdgdesktopinst
branch
from
a87672a
to
da76d7b
Compare
Artturin
force-pushed
the
xdgdesktopinst
branch
from
da76d7b
to
f6d0724
Compare
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.