Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google provider accepts additional authentication params #734

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jamedjo
Copy link

@Jamedjo Jamedjo commented Oct 28, 2015

Allows setting config.google.auth_params = {access_type: :offline, hd: 'mydomain.com'}
Solves #702

A better solution might be to merge these params with the ones hard coded in oauth2.rb and passed to client.auth_code.authorize_url. That would then make it easier to extend this to other providers, e.g. to add include_email for #719. I've instead used the auth_url to avoid changing the Sorcery::Protocols::Oauth2#authorize_url method signature for everyone. If you prefer I'll add an extra argument there instead, i.e. authorize_url(options = {}, auth_params = {}).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant