Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Add dependencies for host build #90

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Add dependencies for host build #90

merged 3 commits into from
Dec 21, 2023

Conversation

Himel55
Copy link
Contributor

@Himel55 Himel55 commented Dec 20, 2023

This fixes #89

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@coderbyheart coderbyheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a compile job to the checks that shows that this solves the problem, so that in the future it does not accidentally get removed ... again.

@Himel55 Himel55 requested a review from coderbyheart December 20, 2023 12:40
Copy link
Member

@coderbyheart coderbyheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderbyheart
Copy link
Member

Board does not exist in 2.4 branch

@Himel55
Copy link
Contributor Author

Himel55 commented Dec 21, 2023

Not sure what the best way to handle this.

I have created separate configs to handle new board type (native_sim now recommended by zephyr https://docs.zephyrproject.org/latest/boards/posix/native_posix/doc/index.html#overview) vs old (native_posix).

I did a dry run this time to make sure they all build successfully.
https://github.com/Himel55/nrf-docker/pull/1

@coderbyheart coderbyheart merged commit bbffe70 into NordicPlayground:saga Dec 21, 2023
8 checks passed
@coderbyheart
Copy link
Member

Thanks!

@Himel55 Himel55 deleted the fix/add_gcc_multilib branch December 21, 2023 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCC missing for native_sim target
3 participants