Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] account_payment_paired_internal_transfer: use same date of payment #661

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[14.0][FIX] account_payment_paired_internal_transfer: use same date of payment #661

merged 1 commit into from
Aug 10, 2023

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Aug 2, 2023

This PR fixes an error when creating the internal transfer, the date defined of the other move is the creation date instead of the transfer date

@alan196
[FIX] account_payment_paired_internal_transfer: consider the same dat…
ed07e4f 
…e of the payment to create the other internal transfer
@alan196
Copy link
Contributor Author

alan196 commented Aug 2, 2023

@EduardoJarsa Could you help me to review 🙏

@rafaelbn rafaelbn mentioned this pull request Aug 9, 2023
Closed
@rafaelbn
Copy link
Member

rafaelbn commented Aug 9, 2023

Please @alan196 , review #640 from @kaynnan @marcelsavegnago @douglascstd

Same module

Non writed OCA Rule from the big @gurneyalex ! If you make a PR, before of after review 3 PRs from other contributors and then OCA will be sustainable! ❤️ 🙏🏼 😄 Thank you!

kaynnan
kaynnan approved these changes Aug 9, 2023
View reviewed changes
Copy link

@kaynnan kaynnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaelbn
Copy link
Member

This PR Fixes #626

@rafaelbn rafaelbn mentioned this pull request Aug 10, 2023
Closed
rafaelbn
rafaelbn approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rvalyi
Copy link
Member

rvalyi commented Aug 10, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-661-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b9f7da5 into OCA:14.0 Aug 10, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f039689. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 14.0-fix-account_payment_paired_internal_transfer branch August 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaynnan kaynnan kaynnan approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alan196 @rafaelbn @OCA-git-bot @rvalyi @kaynnan